Remove cudf._lib.csv in favor in inlining pylibcudf #17485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
Matt711
reviewed
Dec 5, 2024
| def _get_plc_data_type_from_dtype(dtype) -> plc.DataType: | ||
| # TODO: Remove this work-around Dictionary types | ||
| # in libcudf are fully mapped to categorical columns: | ||
| # https://github.com/rapidsai/cudf/issues/3960 |
There was a problem hiding this comment.
Do you know what this TODO entails? It looks like issue linked is closed.
There was a problem hiding this comment.
I'm not certain; it looks like this description changed in #12571.
I'm guessing that it may have to do with the CSV reader round tripping when cudf Python starts with a categorical dtype? @galipremsagar
There was a problem hiding this comment.
Nonetheless, I suppose this can be addressed in a follow-up
There was a problem hiding this comment.
Ok, addressing this in a follow up is fine with me.
Matt711
approved these changes
Dec 12, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #17317
Checklist