Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cuda-python cuda.bindings import names. #17585

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 12, 2024

Description

This PR updates cuDF to use the new cuda-python cuda.bindings layout. See rapidsai/build-planning#117.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Dec 12, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Dec 12, 2024
@bdice bdice added feature request New feature or request non-breaking Non-breaking change labels Dec 12, 2024
@bdice bdice changed the title Replace old import names with new cuda.bindings names. Use new cuda-python cuda.bindings import names. Dec 12, 2024
@bdice bdice changed the title Use new cuda-python cuda.bindings import names. Use cuda-python cuda.bindings import names. Dec 12, 2024
@bdice
Copy link
Contributor Author

bdice commented Dec 12, 2024

/ok to test

@bdice bdice added improvement Improvement / enhancement to an existing function and removed feature request New feature or request labels Dec 12, 2024
@Matt711
Copy link
Contributor

Matt711 commented Dec 17, 2024

Is this PR ready for review?

@bdice bdice marked this pull request as ready for review December 17, 2024 23:12
@bdice bdice requested review from a team as code owners December 17, 2024 23:12
@github-actions github-actions bot added the cudf.polars Issues specific to cudf.polars label Dec 17, 2024
@bdice
Copy link
Contributor Author

bdice commented Dec 17, 2024

@Matt711 Now it is, I hope. Thanks for the ping.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving these and removing the warnings filters!

One conda-python-tests job was failing like this:

Unexpected error 9 on netlink descriptor 5.
/usr/local/bin/rapids-conda-retry: line 68:   811 Aborted                 (core dumped) ${RAPIDS_OTEL_WRAPPER:-} ${condaCmd} ${args} 2>&1
       812 Done                    | tee "${outfile}"
[rapids-conda-retry] conda returned exit code: 134
[rapids-conda-retry] Exiting, no retryable mamba errors detected: 'ChecksumMismatchError:', 'ChunkedEncodingError:', 'CondaHTTPError:', 'CondaMultiError:', 'CondaSSLError:', 'Connection broken:', 'ConnectionError:', 'DependencyNeedsBuildingError:', 'EOFError:', 'JSONDecodeError:', 'Multi-download failed', 'Timeout was reached', segfault exit code 139
[rapids-conda-retry] 

(build link)

I've restarted it.

@bdice
Copy link
Contributor Author

bdice commented Dec 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3add496 into rapidsai:branch-25.02 Dec 20, 2024
104 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants