Expose stream-ordering in scalar and avro APIs #17766
Open
+87
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
shrshi
added
improvement
bdice
reviewed
Jan 18, 2025
| */ | ||
| explicit operator value_type() const; | ||
| T get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
There was a problem hiding this comment.
RMM just calls this value. We often try to avoid “get” in our function names.
Suggested change
| T get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; | |
| T value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
There was a problem hiding this comment.
Wait, doesn’t value already exist just below here? We may not need get_value at all. Maybe we just need to delete the conversion operator since it does not take a stream.
| */ | ||
| explicit operator value_type() const; | ||
| T get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
There was a problem hiding this comment.
Maybe we should delete this. There are already value and fixed_point_value functions.
| */ | ||
| explicit operator std::string() const; | ||
| std::string get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
| @@ -81,7 +81,7 @@ void ASSERT_BINOP(cudf::column_view const& out, | |||
| TypeOp&& op, | |||
| ValueComparator const& value_comparator = ValueComparator()) | |||
| { | |||
| auto lhs_h = static_cast<ScalarType const&>(lhs).operator TypeLhs(); | |||
| auto lhs_h = static_cast<ScalarType const&>(lhs).get_value(cudf::get_default_stream()); | |||
There was a problem hiding this comment.
Please refactor the tests like this:
Suggested change
| auto lhs_h = static_cast<ScalarType const&>(lhs).get_value(cudf::get_default_stream()); | |
| auto lhs_h = static_cast<ScalarType const&>(lhs).value(cudf::get_default_stream()); |
This was referenced Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #13744
Replaces conversion operators in derived classes of
cudf::scalarwith stream-orderedget_value(stream)member function.Adds stream parameter to
cudf::io::read_avroChecklist