Code

Implement drop_list_duplicates#7528

Code

Merged

rapids-bot[bot] merged 25 commits intorapidsai:branch-0.19rapidsai/cudf:branch-0.19from ttnghia:drop_list_duplicatesttnghia/cudf:drop_list_duplicatesCopy head branch name to clipboardMar 12, 2021

+548

Commits

Commits on Mar 3, 2021

• Add drop_list_duplicates implementation

  ttnghia

  committed
  e0ec1a5

  Copy full SHA for e0ec1a5

• Add tests for drop_list_duplicates

  ttnghia

  committed
  cae114b

  Copy full SHA for cae114b

Commits on Mar 5, 2021

• Draft implementation for drop_list_duplicates

  ttnghia

  committed
  d07265f

  Copy full SHA for d07265f

• Draft test for drop_list_duplicates

  ttnghia

  committed
  1fdb2a4

  Copy full SHA for 1fdb2a4

Commits on Mar 7, 2021

• Complete implementation - fix bugs and handle empty lists

  ttnghia

  committed
  4e9231e

  Copy full SHA for 4e9231e

• Update documentation for drop_list_duplicates

  ttnghia

  committed
  5a92288

  Copy full SHA for 5a92288

• Complete unit tests for drop_list_duplicates

  ttnghia

  committed
  eaee403

  Copy full SHA for eaee403

• Rewrite unit tests for drop_list_duplicates

  ttnghia

  committed
  fbb7261

  Copy full SHA for fbb7261

• Update conda recipes

  ttnghia

  committed
  23395a6

  Copy full SHA for 23395a6

Commits on Mar 8, 2021

• Remove nan from testing, since comparing with nan produces undefined order.

  ttnghia

  committed
  e865030

  Copy full SHA for e865030

• Address review comments: Change doxygen group, change thrust::copy_if to thrust::unique_copy, change comment style, and fix bug (incorrect offset handling for sliced column)

  ttnghia

  committed
  8176951

  Copy full SHA for 8176951

• Address review comments: Change comment style, and add an TODO item to the unit tests

  ttnghia

  committed
  985d3c3

  Copy full SHA for 985d3c3

• Fix a bug in unique copy that forgot to check whether 2 entries are from the same list or not

  ttnghia

  committed
  e235710

  Copy full SHA for e235710

• Add a corner test case for drop_list_duplicates

  ttnghia

  committed
  897adc9

  Copy full SHA for 897adc9

Commits on Mar 9, 2021

• Change comments in unit tests of drop_list_duplicates

  ttnghia

  committed
  27bc327

  Copy full SHA for 27bc327

• Address review comments: Change size_type to offset_type and use default the device resource for allocating temporary memory

  ttnghia

  committed
  8fe0e98

  Copy full SHA for 8fe0e98

Commits on Mar 10, 2021

• Address review comments: Change coding style and clean up

  ttnghia

  committed
  d879b01

  Copy full SHA for d879b01

• Change comments

  ttnghia

  committed
  b22252d

  Copy full SHA for b22252d

• Address review comments: Remove unused variable, shortening the codes, and fix example in the comments

  ttnghia

  committed
  3f7956b

  Copy full SHA for 3f7956b

• Add CUDF_FUNC_RANGE() to the public drop_list_duplicate API

  ttnghia

  committed
  c759c98

  Copy full SHA for c759c98

Commits on Mar 11, 2021

• Address review comments: Using the detail::sort_lists API to sort list elements, which takes into account the current stream value

  ttnghia

  committed
  3bf0df3

  Copy full SHA for 3bf0df3

• Switch to use the default device resource for detail::sort_lists

  ttnghia

  committed
  e8b6ed3

  Copy full SHA for e8b6ed3

• Add tests for sliced lists column

  ttnghia

  committed
  6fa8744

  Copy full SHA for 6fa8744

• Update cpp/tests/lists/drop_list_duplicates_tests.cpp

  Show description for 36d5822
  

  ttnghia

  and

  davidwendt

  authored
  36d5822

  Copy full SHA for 36d5822

Commits on Mar 12, 2021

• Fix style error in drop_list_duplicates_tests.cpp

  ttnghia

  committed
  ae68606

  Copy full SHA for ae68606