Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNI: Pass names of children struct columns to native Arrow IPC writer [skip ci] #7598

Merged
merged 16 commits into from
Mar 20, 2021
Merged

JNI: Pass names of children struct columns to native Arrow IPC writer [skip ci] #7598

merged 16 commits into from
Mar 20, 2021

Commits on Mar 15, 2021

  1. Pass names of children struct columns to native 

    Pass the names of children struct columns to the naitve for arrow
IPC writer, which is required to build column_metadata.

Also add the related unit tests.

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    1c8d676 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Add a metadata for offset column of array type. 

    This is required by native.

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6adafda View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Use the regular JNI call to create the c++ column meta 

    Do this to avoid callback callback into the JVM.

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    44fa204 View commit details
    Browse the repository at this point in the history

  2. Correct the year 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    a767e70 View commit details
    Browse the repository at this point in the history

  3. comment update 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d83d0e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Align with the flattened name approach. 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    4c2eeef View commit details
    Browse the repository at this point in the history

  2. Return a reference from get_column_name 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    fbbbe5b View commit details
    Browse the repository at this point in the history

  3. Update the function signaure 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    bc33abc View commit details
    Browse the repository at this point in the history

  4. correct the child index of array type column 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    eb39f16 View commit details
    Browse the repository at this point in the history

  5. Correct the index for list type 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    55a1e17 View commit details
    Browse the repository at this point in the history

  6. Comment update 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    07d09e5 View commit details
    Browse the repository at this point in the history

  7. Remove unexpected rmm log file 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    87d403a View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Address some comments 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    1f21c3a View commit details
    Browse the repository at this point in the history

  2. error message update 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    420f524 View commit details
    Browse the repository at this point in the history

  3. Only root columns and nested struct columns consume names 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    b8966a0 View commit details
    Browse the repository at this point in the history

  4. error message update 

    Signed-off-by: Firestarman <firestarmanllc@gmail.com>
    @firestarman
    firestarman committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    54395f0 View commit details
    Browse the repository at this point in the history