-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and promote library aliases in libcudf installations #7734
Create and promote library aliases in libcudf installations #7734
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7734 +/- ##
===============================================
+ Coverage 81.86% 82.52% +0.65%
===============================================
Files 101 101
Lines 16884 17458 +574
===============================================
+ Hits 13822 14407 +585
+ Misses 3062 3051 -11
Continue to review full report at Codecov.
|
conda/recipes/libcudf/meta.yaml
Outdated
- gtest | ||
- gmock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given these are only required if someone uses cudftestutil
, how would we feel about not including these and if someone uses cudftestutil
they're required to have gtest
/ gmock
installed in their environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine with me, just means we have to install them into the gpuCI containers and block merging until the next nightly release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change was in reference to rapidsai/cuspatial#365 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should already be in the gpuci build environment: https://github.com/rapidsai/integration/blob/branch-0.19/conda/recipes/rapids-build-env/meta.yaml#L78-L80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we had a run on gpuCI where these didn't work? We install the rapids-build-env
in all gpuCI images that we build with so both gtest
/gmock
should be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cuSpatial build failed because CMake couldn't find GTest:
cudf could not be found because dependency GTest could not be found.
But the real reason could due to cuDF not having the changes in this PR. I'll remove these here and in cuSpatial and see what happens.
@gpucibot merge |
This PR includes many of the same changes as were made in [cudf/pull/7107](rapidsai/cudf#7107). * Export `cuspatial::cuspatial` CMake alias targets. * Fixes -Wall errors discovered when changing compile flags. * Use `CPMFindPackage` to find `libcudf` installed on the system or build `libcudf` from source. edit: Depends on rapidsai/cudf#7574 and rapidsai/cudf#7734 Authors: - Paul Taylor (@trxcllnt) Approvers: - AJ Schmidt (@ajschmidt8) - Mark Harris (@harrism) - Keith Kraus (@kkraus14) URL: #365
This PR ensures all
cudf::*
library aliases are created and promoted toIMPORTED_GLOBAL
whenfind_package(cudf)
finds cudf in a local build directory.This PR shouldn't affect CI or the targets you'd see whenlibcudf
is installed (e.g. by conda), only local source builds.edit: This now fixes
cudf::*
alias targets for thelibcudf
installations too, needed by rapidsai/cuspatial#365.Validation method: