Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add ignore_order parameter to dask-cudf concat dispatch #7765

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

galipremsagar
Copy link
Contributor

A new parameter was added to dask upstream which is breaking dask-cudf: dask/dask#7398

In this PR added that parameter to unblock the breakage.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Mar 30, 2021
@galipremsagar galipremsagar self-assigned this Mar 30, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner March 30, 2021 21:04
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 30, 2021
@jakirkham jakirkham added the non-breaking Non-breaking change label Mar 30, 2021
@jakirkham
Copy link
Member

cc @rjzamora (for vis)

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Mar 30, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #7765 (aeb7374) into branch-0.19 (7871e7a) will increase coverage by 0.80%.
The diff coverage is n/a.

❗ Current head aeb7374 differs from pull request most recent head 29b3519. Consider uploading reports for the commit 29b3519 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7765      +/-   ##
===============================================
+ Coverage        81.86%   82.67%   +0.80%     
===============================================
  Files              101      101              
  Lines            16884    17430     +546     
===============================================
+ Hits             13822    14410     +588     
+ Misses            3062     3020      -42     
Impacted Files Coverage Δ
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 87.68% <0.00%> (-3.72%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/core/column/decimal.py 93.84% <0.00%> (-1.03%) ⬇️
python/cudf/cudf/core/column/column.py 87.53% <0.00%> (-0.23%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9212b...29b3519. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 4ee52f3 into rapidsai:branch-0.19 Mar 31, 2021
@jakirkham
Copy link
Member

Thanks Prem! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants