Cleanup using C++17 features #7931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
3 - Ready for Review
ttnghia
reviewed
Apr 10, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7931 +/- ##
===============================================
+ Coverage 82.30% 82.71% +0.41%
===============================================
Files 101 103 +2
Lines 17053 17702 +649
===============================================
+ Hits 14035 14643 +608
- Misses 3018 3059 +41
Continue to review full report at Codecov.
|
ttnghia
approved these changes
Apr 10, 2021
mythrocks
approved these changes
Apr 10, 2021
codereport
added
5 - Ready to Merge
|
@gpucibot merge |
Comment on lines
+58
to
+59
| auto const min = std::min(lhs, rhs); | ||
| auto const max = std::max(lhs, rhs); |
There was a problem hiding this comment.
Why not minmax as mentioned in the comment?
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Apr 13, 2021
cuDF 0.20 headers [now use C++17 features](rapidsai/cudf#7931), so we need to update to C++17 also. We will also need to update CI images to use gcc-9, as C++17 support is incomplete in gcc-7 and gcc-8. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Keith Kraus (https://github.com/kkraus14) - Christopher Harris (https://github.com/cwharris) - AJ Schmidt (https://github.com/ajschmidt8) URL: #382
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
Small cleanup PR. Follow up to #7931 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Mark Harris (https://github.com/harrism) - Robert Maynard (https://github.com/robertmaynard) URL: #8089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup PR