Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up more literal zero cuda_stream_view arguments #7968

Merged

Conversation

davidwendt
Copy link
Contributor

Reference #7774
Some more changes to files created after the previous cleanup.
This PR fixes places using the literal '0' parameter instead of rmm::cuda_stream_default

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Apr 15, 2021
@davidwendt davidwendt self-assigned this Apr 15, 2021
@davidwendt davidwendt requested a review from a team as a code owner April 15, 2021 16:10
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #7968 (cbd2501) into branch-0.20 (599f62d) will increase coverage by 0.42%.
The diff coverage is 92.73%.

❗ Current head cbd2501 differs from pull request most recent head 5bf0b9f. Consider uploading reports for the commit 5bf0b9f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7968      +/-   ##
===============================================
+ Coverage        82.30%   82.72%   +0.42%     
===============================================
  Files              101      103       +2     
  Lines            17053    17714     +661     
===============================================
+ Hits             14035    14654     +619     
- Misses            3018     3060      +42     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <ø> (-6.45%) ⬇️
python/cudf/cudf/utils/utils.py 83.25% <ø> (-1.81%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <ø> (-0.05%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <78.57%> (-1.04%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <80.00%> (+0.19%) ⬆️
python/cudf/cudf/core/column/struct.py 96.29% <86.66%> (-3.71%) ⬇️
python/cudf/cudf/core/index.py 93.04% <88.09%> (+0.01%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <88.57%> (+0.43%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 91.11% <92.30%> (+0.48%) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9617fcd...5bf0b9f. Read the comment docs.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8a504d1 into rapidsai:branch-0.20 Apr 15, 2021
@davidwendt davidwendt deleted the zero-literal-cuda_stream_view branch April 15, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants