Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace remaining uses of device_vector #8343

Merged
merged 6 commits into from
Jun 2, 2021
Merged

Replace remaining uses of device_vector #8343

merged 6 commits into from
Jun 2, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented May 25, 2021 •
edited
Loading

Replaces device_vector with device_uvector in decomp_test.cu (now .cpp) and quantile.cu.

Also updates DEVELOPER_GUIDE.md to advise against using device_vector.

Closes #2631

@harrism harrism requested a review from a team as a code owner May 25, 2021 02:22
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels May 25, 2021
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 25, 2021
@harrism harrism self-assigned this May 25, 2021
@harrism
Copy link
Member Author

harrism commented May 26, 2021

rerun tests

ttnghia
ttnghia approved these changes May 28, 2021
View reviewed changes
cpp/tests/io/comp/decomp_test.cpp Outdated Show resolved Hide resolved
@harrism harrism added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 31, 2021
@harrism
Copy link
Member Author

harrism commented Jun 2, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Jun 2, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f31a094). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8343   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31a094...59d9442. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 48a2663 into rapidsai:branch-21.08 Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@ttnghia ttnghia ttnghia approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees

@harrism harrism

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Mixing rmm::device_vector and non-default stream is unsafe
3 participants
@harrism @ttnghia @rgsl888prabhu