Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update dask make_meta changes to be compatible with dask upstream #8426

Merged
merged 4 commits into from
Jun 4, 2021
Merged

[REVIEW] Update dask make_meta changes to be compatible with dask upstream #8426

merged 4 commits into from
Jun 4, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jun 2, 2021 •
edited
Loading

This PR updates the make_meta dispatch renaming to be compatible and back-ward compatible with latest dask and older versions of dask respectively.

This PR needs upstream dask changes: dask/dask#7743

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 5 - Merge After Dependencies 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function breaking Breaking change labels Jun 2, 2021
@galipremsagar galipremsagar self-assigned this Jun 2, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner June 2, 2021 00:28
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 2, 2021
@jakirkham jakirkham mentioned this pull request Jun 2, 2021
Merged
@galipremsagar galipremsagar mentioned this pull request Jun 2, 2021
Merged
3 tasks
@galipremsagar galipremsagar removed 5 - DO NOT MERGE Hold off on merging; see PR for details 5 - Merge After Dependencies labels Jun 3, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 3, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@quasiben
Copy link
Member

quasiben commented Jun 3, 2021

rerun tests

@jakirkham jakirkham mentioned this pull request Jun 3, 2021
Merged
@jakirkham
Copy link
Member

jakirkham commented Jun 3, 2021 •
edited
Loading

Think we need to merge PR ( rapidsai/dask-cuda#637 ) first for CI to pass

Edit: IOW we have a catch 22

@jakirkham
Copy link
Member

rerun tests

(dask-cuda packages are up)

@pentschev pentschev mentioned this pull request Jun 3, 2021
Merged
@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@d8fbb19). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8426   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fbb19...added61. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 37cdc71 into rapidsai:branch-21.08 Jun 4, 2021
This was referenced Jun 11, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @quasiben @jakirkham