-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace make_empty_strings_column with make_empty_column #8435
Replace make_empty_strings_column with make_empty_column #8435
Conversation
I wonder why don't we call |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8435 +/- ##
===============================================
Coverage ? 82.83%
===============================================
Files ? 109
Lines ? 17901
Branches ? 0
===============================================
Hits ? 14828
Misses ? 3073
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
Closes #8352
This PR replaces the
cudf::strings::detail::make_empty_strings_column
call with the existingcudf::make_empty_column(cudf::data_type{cudf::type_id::STRING})
instead.This allowed also removing the include of
cudf/strings/detail/utilities.hpp
from some source files as well.No function has changed. The
make_empty_strings_column
detail utility is removed.