Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum Dask requirement to 2021.6.0 #8458

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Update minimum Dask requirement to 2021.6.0 #8458

merged 1 commit into from
Jun 9, 2021

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Jun 8, 2021 •
edited
Loading

We need Dask >= 2021.6.0 to resolve the make_meta issue fixed in dask/dask#7743 , thus updating minimum Dask/Distributed requirement.

Fixes #8457

@pentschev pentschev requested review from a team as code owners June 8, 2021 14:49
@pentschev
Copy link
Member Author

cc @randerzander @quasiben @jakirkham

@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Jun 8, 2021
@quasiben
Copy link
Member

quasiben commented Jun 8, 2021

In this PR are you trying to change the dev environments, the releases, nightlies, or all three ?

Note that for CI testing we do not use any pins:
#8425

@pentschev
Copy link
Member Author

All three, that's because we need to ensure package versions, whereas CI is installing from source.

@quasiben
Copy link
Member

quasiben commented Jun 8, 2021

The last two releases we've been pinning a maximum version of dask/distributed. When we get to the 21.08 we will probably need to change things to restrict to a new maximum

@pentschev
Copy link
Member Author

Right, but 21.08 is still unreleased, do we want to pin to a max version during development?

@jakirkham
Copy link
Member

cc @galipremsagar

@jakirkham
Copy link
Member

We could also just pin to this Dask + Distributed release for now and slowly relax that as new releases come out

@quasiben
Copy link
Member

quasiben commented Jun 8, 2021

I think it's ok to unpin during development. But I think it would be good to hear from @galipremsagar and/or @shwina

@shwina
Copy link
Contributor

shwina commented Jun 8, 2021

Should be fine to unpin during development.

@quasiben quasiben added the non-breaking Non-breaking change label Jun 8, 2021
@quasiben quasiben added the improvement Improvement / enhancement to an existing function label Jun 8, 2021
@galipremsagar galipremsagar added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jun 8, 2021
@galipremsagar
Copy link
Contributor

We'll need integration repo changes too: https://github.com/rapidsai/integration, but would probably need to hold off until branch-21.08 is created in that repo.

@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@90e29d9). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f5e8529 differs from pull request most recent head 6212109. Consider uploading reports for the commit 6212109 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8458   +/-   ##
===============================================
  Coverage                ?   82.84%           
===============================================
  Files                   ?      109           
  Lines                   ?    17913           
  Branches                ?        0           
===============================================
  Hits                    ?    14840           
  Misses                  ?     3073           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e29d9...6212109. Read the comment docs.

@quasiben
Copy link
Member

quasiben commented Jun 9, 2021

If we merged this PR while we waited for the integration repo issue to be resolved what would happen ? Nightly Docker Images would still be broken ? Anything else ?

@pentschev
Copy link
Member Author

If we merged this PR while we waited for the integration repo issue to be resolved what would happen ? Nightly Docker Images would still be broken ? Anything else ?

My understanding is this will unblock at least those environments that don't necessarily depend on other packages that may encounter the same type of issue this PR is trying to solve. I'm not sure what would happen to the Docker images, but I think this shouldn't introduce any new issues.

With the above said, should we merge this? We have several approvals, but it's not entirely clear to me if we should hold until integration creates branch-21.08.

trxcllnt added a commit to trxcllnt/cuml that referenced this pull request Jun 9, 2021
@trxcllnt
Update dask/distributed versions to align with cuDF
01b3f85 
rapidsai/cudf#8458
@trxcllnt trxcllnt mentioned this pull request Jun 9, 2021
Merged
@ajschmidt8
Copy link
Member

branch-21.08 has been created in the integration repo
https://github.com/rapidsai/integration/tree/branch-21.08

@ajschmidt8 ajschmidt8 mentioned this pull request Jun 9, 2021
Merged
@galipremsagar galipremsagar mentioned this pull request Jun 9, 2021
Merged
@galipremsagar galipremsagar removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jun 9, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 460d2b9 into rapidsai:branch-21.08 Jun 9, 2021
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jun 16, 2021
@trxcllnt
Promote trustworthiness_score to public header, add missing include…
afdeda9 
…s, update dependencies (#3968)

* Updates dask/distributed versions to match cuDF (rapidsai/cudf#8458)
* Updates to Thrust v1.12.0 to align with cuDF and cuGraph
* Don't include the src and src_prims directories in `cuml::cuml++` target's public include paths
* Add missing `<cstddef>` and `<cstdint>` include directives
* Promote `trustworthiness_score` to public `cuml/metrics/metrics.hpp` header and update Cython
* Compile Cython with `-std=c++17`
* Remove `-Wstrict-prototypes` Cython warning
* Fixes linker error in debug builds
* Fixes #3885

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #3968
@pentschev pentschev deleted the update-dask-2021.6.0 branch June 28, 2021 11:01
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@trxcllnt
Promote trustworthiness_score to public header, add missing include…
f630f69 
…s, update dependencies (rapidsai#3968)

* Updates dask/distributed versions to match cuDF (rapidsai/cudf#8458)
* Updates to Thrust v1.12.0 to align with cuDF and cuGraph
* Don't include the src and src_prims directories in `cuml::cuml++` target's public include paths
* Add missing `<cstddef>` and `<cstdint>` include directives
* Promote `trustworthiness_score` to public `cuml/metrics/metrics.hpp` header and update Cython
* Compile Cython with `-std=c++17`
* Remove `-Wstrict-prototypes` Cython warning
* Fixes linker error in debug builds
* Fixes rapidsai#3885

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#3968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@jakirkham jakirkham jakirkham approved these changes

@quasiben quasiben quasiben approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Can't import dask_cudf in latest cudf nightlies
6 participants
@pentschev @quasiben @jakirkham @shwina @galipremsagar @ajschmidt8