Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda-sourced cudf artifacts for libcudf example in CI #8638

Merged
merged 7 commits into from
Jul 21, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jul 1, 2021

This PR lets libcudf examples build on top of existing cudf artifacts in CI.

After speaking with @robertmaynard , this PR moves libcudf example building using libcudf pulled from conda sources.

@isVoid isVoid requested a review from a team as a code owner July 1, 2021 19:53
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 1, 2021
@isVoid isVoid changed the title Let CI example build find previously built cudf artifacts Libcudf example build find previously built cudf artifacts in CI Jul 1, 2021
@isVoid isVoid self-assigned this Jul 1, 2021
@isVoid isVoid added bug Something isn't working non-breaking Non-breaking change gpuCI labels Jul 1, 2021
@isVoid isVoid changed the title Libcudf example build find previously built cudf artifacts in CI Use previously built cudf artifacts for libcudf example in CI Jul 1, 2021
@github-actions github-actions bot removed the gpuCI label Jul 1, 2021
@trxcllnt
Copy link
Contributor

trxcllnt commented Jul 1, 2021

rerun tests

rapids-bot bot pushed a commit that referenced this pull request Jul 2, 2021
Currently when CI build libcudf examples, it rebuilds the entire libcudf library. Until we figure out how to reuse the built libcudf artifacts in CI, we should disable the build to save CI build times.

Looking to be re-enabled by #8638

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #8642
@isVoid isVoid requested a review from a team as a code owner July 6, 2021 21:26
@ajschmidt8
Copy link
Member

@isVoid, can you merge the latest again to get the recently merged clang update?

7721819

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@b123eb8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b16c0d9 differs from pull request most recent head 024ef2a. Consider uploading reports for the commit 024ef2a to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8638   +/-   ##
===============================================
  Coverage                ?   10.63%           
===============================================
  Files                   ?      109           
  Lines                   ?    18667           
  Branches                ?        0           
===============================================
  Hits                    ?     1985           
  Misses                  ?    16682           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b123eb8...024ef2a. Read the comment docs.

@isVoid isVoid changed the title Use previously built cudf artifacts for libcudf example in CI Use conda-sourced cudf artifacts for libcudf example in CI Jul 15, 2021
@isVoid isVoid added the 3 - Ready for Review Ready for review by team label Jul 15, 2021
@devavret devavret removed their request for review July 19, 2021 08:36
@harrism
Copy link
Member

harrism commented Jul 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7e3b76e into rapidsai:branch-21.08 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants