Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix where to handle DataFrame & Series input combination #8747

Merged
merged 4 commits into from
Jul 16, 2021
Merged

[REVIEW] Fix where to handle DataFrame & Series input combination #8747

merged 4 commits into from
Jul 16, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jul 15, 2021 •
edited
Loading

Fixes: #7383

  • Fix where API to handle DataFrame & Series combination correctly.
  • Add tests

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 15, 2021
@galipremsagar galipremsagar added the 2 - In Progress Currently a work in progress label Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@798c8d2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8747   +/-   ##
===============================================
  Coverage                ?   10.69%           
===============================================
  Files                   ?      110           
  Lines                   ?    18641           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16648           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798c8d2...8d16ca7. Read the comment docs.

@galipremsagar galipremsagar changed the title [WIP] Fix where to handle Series inputs [WIP] Fix where to handle DataFrame & Series input combination Jul 15, 2021
@galipremsagar galipremsagar marked this pull request as ready for review July 15, 2021 19:47
@galipremsagar galipremsagar requested a review from a team as a code owner July 15, 2021 19:47
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels Jul 15, 2021
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Jul 15, 2021
@galipremsagar galipremsagar changed the title [WIP] Fix where to handle DataFrame & Series input combination [REVIEW] Fix where to handle DataFrame & Series input combination Jul 15, 2021
charlesbluca
charlesbluca approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small unrelated question

python/cudf/cudf/core/_internals/where.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jul 15, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 41b3671 into rapidsai:branch-21.08 Jul 16, 2021
@sarahyurick sarahyurick mentioned this pull request Aug 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] where needs to handle Series inputs aswell
2 participants
@galipremsagar @charlesbluca