Bump isort to 5.6.4 and remove isort overrides made for 5.0.7
#8755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
added
feature request
charlesbluca
commented
Jul 16, 2021
| @@ -1,5 +1,5 @@ | |||
| # Copyright (c) 2018-2021, NVIDIA CORPORATION. | |||
| from cudf.utils.gpu_utils import validate_setup # isort:skip | |||
| from cudf.utils.gpu_utils import validate_setup | |||
There was a problem hiding this comment.
Just pointing out that this is an unrelated override that can also be removed as this line will not be resorted by 5.6.4
ajschmidt8
approved these changes
Jul 16, 2021
galipremsagar
approved these changes
Jul 16, 2021
galipremsagar
requested changes
Jul 16, 2021
There was a problem hiding this comment.
We need to bump versions in dev .yml files: https://github.com/rapidsai/cudf/tree/branch-21.08/conda/environments
and also requirements.txt files that are in this repo.
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8755 +/- ##
===============================================
Coverage ? 10.54%
===============================================
Files ? 116
Lines ? 18907
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16914
Partials ? 0 Continue to review full report at Codecov.
|
galipremsagar
changed the title
isort overrides made for 5.0.7isort to 5.6.4 and remove isort overrides made for 5.0.7
galipremsagar
approved these changes
Jul 16, 2021
rjzamora
approved these changes
Jul 16, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jul 19, 2021
Update isort to 5.6.4 to match cudf. rapidsai/cudf#8755. also remove unused references to nvstrings/nvcategory. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - AJ Schmidt (https://github.com/ajschmidt8) URL: #822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to rapidsai/integration#286 being merged and bumping gpuCI's
isortversion to 5.6.4, this removes the temporary overrides made to avoid failures with the old conflicting version.