Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cuda-memcheck errors for some libcudf functions #8941

Merged
merged 13 commits into from
Aug 13, 2021

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Aug 3, 2021

Reference #8883

This PR fixes cuda-memcheck errors found in STRINGS_TEST TEXT_TEST, CSV_TEST and GROUPBY_TEST. All of these were reading outside the bounds of a device memory buffer. Extra checking was added to the code logic to ensure bytes are not read past the end of given buffer.

These were found a checked using cuda-memcheck gtests/[test-executable] --rmm_mode=cuda since the default pool mode will render all or most device memory as valid readable.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 3, 2021
@davidwendt davidwendt self-assigned this Aug 3, 2021
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 4, 2021
@davidwendt davidwendt marked this pull request as ready for review August 4, 2021 15:51
@davidwendt davidwendt requested a review from a team as a code owner August 4, 2021 15:51
@davidwendt
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@2c5a2ad). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4356ede differs from pull request most recent head 87b1406. Consider uploading reports for the commit 87b1406 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #8941   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    18676           
  Branches                ?        0           
===============================================
  Hits                    ?     1979           
  Misses                  ?    16697           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5a2ad...87b1406. Read the comment docs.

@karthikeyann karthikeyann requested a review from vuule August 7, 2021 04:36
@davidwendt
Copy link
Contributor Author

rerun tests

@vuule
Copy link
Contributor

vuule commented Aug 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit eacc24b into rapidsai:branch-21.10 Aug 13, 2021
@davidwendt davidwendt deleted the bug-memcheck-errors branch November 8, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants