-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cuda-memcheck errors for some libcudf functions #8941
Fix cuda-memcheck errors for some libcudf functions #8941
Conversation
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8941 +/- ##
===============================================
Coverage ? 10.59%
===============================================
Files ? 116
Lines ? 18676
Branches ? 0
===============================================
Hits ? 1979
Misses ? 16697
Partials ? 0 Continue to review full report at Codecov.
|
rerun tests |
@gpucibot merge |
Reference #8883
This PR fixes cuda-memcheck errors found in
STRINGS_TEST
TEXT_TEST
,CSV_TEST
andGROUPBY_TEST
. All of these were reading outside the bounds of a device memory buffer. Extra checking was added to the code logic to ensure bytes are not read past the end of given buffer.These were found a checked using
cuda-memcheck gtests/[test-executable] --rmm_mode=cuda
since the defaultpool
mode will render all or most device memory as valid readable.