cudf now leverages rapids-cmake to reduce CMake boilerplate #9030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
2 - In Progress
robertmaynard
force-pushed
the
fea/cudf_use_rapids_cmake
branch
from
43940bc
to
3d503ca
Compare
|
rerun tests |
robertmaynard
force-pushed
the
fea/cudf_use_rapids_cmake
branch
from
3d503ca
to
2075fb2
Compare
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9030 +/- ##
===============================================
Coverage ? 10.76%
===============================================
Files ? 114
Lines ? 19085
Branches ? 0
===============================================
Hits ? 2054
Misses ? 17031
Partials ? 0 Continue to review full report at Codecov.
|
robertmaynard
force-pushed
the
fea/cudf_use_rapids_cmake
branch
2 times, most recently
from
095cfb3
to
40f160d
Compare
|
rerun tests |
1 similar comment
|
rerun tests |
robertmaynard
force-pushed
the
fea/cudf_use_rapids_cmake
branch
4 times, most recently
from
25a34e9
to
708799e
Compare
rapids-cmake providies features such as dependency tracking, pre-configured CPM dependencies, and CUDA architecture detction. Using those features allows cudf to reduce the amount of CMake code it needs to mantain, and brings it inline with the rest of RAPIDS.
robertmaynard
force-pushed
the
fea/cudf_use_rapids_cmake
branch
from
708799e
to
ebe60c0
Compare
|
rerun tests |
jlowe
approved these changes
Aug 19, 2021
|
I don't believe my review is needed. |
harrism
requested changes
Aug 23, 2021
|
I don't feel that I can review this well. |
|
rerun tests |
harrism
approved these changes
Aug 25, 2021
robertmaynard
added
3 - Ready for Review
|
@gpucibot merge |
pxLi
reviewed
Sep 2, 2021
Comment on lines
-234
to
-246
| include_directories("${THRUST_INCLUDE}" | ||
| "${CUB_INCLUDE}" | ||
| "${LIBCUDACXX_INCLUDE}" | ||
| "${CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES}" | ||
| "${NVCOMP_INCLUDE_DIR}" | ||
| "${CMAKE_BINARY_DIR}/include" | ||
| "${CMAKE_SOURCE_DIR}/include" | ||
| "${SPDLOG_INCLUDE}" | ||
| "${CMAKE_SOURCE_DIR}/src" | ||
| "${JNI_INCLUDE_DIRS}" | ||
| "${CUDF_INCLUDE}" | ||
| "${RMM_INCLUDE}" | ||
| "${ARROW_INCLUDE}") |
There was a problem hiding this comment.
Thanks for fixing that regression, sorry I introduced it
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
When #9030 was merged it incorrectly resolved `get_cucollections.cmake` to use features of `rapids_cpm_find` but still call `CPMFindPackage`. This corrects the issues by properly calling `rapids_cpm_find`. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Keith Kraus (https://github.com/kkraus14) - Mark Harris (https://github.com/harrism) URL: #9189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapids-cmake providies features such as dependency tracking, pre-configured CPM dependencies, and CUDA architecture detction.
Using those features allows cudf to reduce the amount of CMake
code it needs to maintain, and brings it inline with the rest
of RAPIDS.