Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java table partition test to account for non-deterministic ordering #9385

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Oct 6, 2021

Contributes to #9375.

TableTest#testPartition was written with the assumption that the ordering within each partition would match the relative ordering within the input table, but this is not guaranteed. Updated the test to sort each partition before comparing against expected results.

@jlowe jlowe added bug Something isn't working tests Unit testing for project Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Oct 6, 2021
@jlowe jlowe self-assigned this Oct 6, 2021
@jlowe jlowe requested a review from a team as a code owner October 6, 2021 13:26
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #9385 (9c5816c) into branch-21.12 (ab4bfaa) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 9c5816c differs from pull request most recent head 721ec10. Consider uploading reports for the commit 721ec10 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9385      +/-   ##
================================================
- Coverage         10.79%   10.74%   -0.05%     
================================================
  Files               116      116              
  Lines             18869    19080     +211     
================================================
+ Hits               2036     2051      +15     
- Misses            16833    17029     +196     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 0.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56edd42...721ec10. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Oct 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4d6ecd1 into rapidsai:branch-21.12 Oct 6, 2021
@jlowe jlowe deleted the fix-java-partition-test branch October 6, 2021 15:13
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants