Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cuCollections to version that supports installed libcudacxx #9633

Conversation

robertmaynard
Copy link
Contributor

The latest version of cuCollections now support using installed versions of libcudacxx. This is needed so that developers can run ./build.sh multiple times without issue.

@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team CMake CMake build issue non-breaking Non-breaking change labels Nov 8, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner November 8, 2021 20:11
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 8, 2021
@vyasr vyasr added the improvement Improvement / enhancement to an existing function label Nov 8, 2021
@vyasr
Copy link
Contributor

vyasr commented Nov 8, 2021

Looks like conflicts are due to your 21.12 predates my CMake formatting PR.

The latest version of cuCollections now support using installed
versions of libcudacxx. This is needed so that developers can
run `./build.sh` multiple times without issue.
@robertmaynard robertmaynard force-pushed the fea/update_to_latest_cuCollections branch from e970239 to e0ed229 Compare November 8, 2021 21:22
@robertmaynard
Copy link
Contributor Author

Looks like conflicts are due to your 21.12 predates my CMake formatting PR.

Conflicts should be resolved now

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #9633 (e0ed229) into branch-21.12 (ab4bfaa) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9633      +/-   ##
================================================
- Coverage         10.79%   10.66%   -0.13%     
================================================
  Files               116      117       +1     
  Lines             18869    19832     +963     
================================================
+ Hits               2036     2115      +79     
- Misses            16833    17717     +884     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34832f6...e0ed229. Read the comment docs.

@vyasr
Copy link
Contributor

vyasr commented Nov 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3280be2 into rapidsai:branch-21.12 Nov 9, 2021
@robertmaynard robertmaynard deleted the fea/update_to_latest_cuCollections branch November 9, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants