Skip to content

Commit

Permalink
Cleanup obsolete visitor code (#3268)
Browse files Browse the repository at this point in the history
Clean up some residual code from the prototype implementation of the C API.

This PR eliminates the `cugraph/visitors` include directory, either eliminating obsolete functionality or moving the functionality into the C API structure.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #3268
  • Loading branch information
ChuckHastings authored Feb 14, 2023
1 parent 8759c9f commit b50850f
Show file tree
Hide file tree
Showing 22 changed files with 189 additions and 1,324 deletions.
17 changes: 3 additions & 14 deletions cpp/include/cugraph/graph_view.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
* Copyright (c) 2020-2023, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -20,10 +20,6 @@
#include <cugraph/utilities/error.hpp>
#include <cugraph/vertex_partition_view.hpp>

// visitor logic:
//
#include <cugraph/visitors/graph_envelope.hpp>

#include <raft/core/device_span.hpp>
#include <raft/core/handle.hpp>
#include <raft/core/host_span.hpp>
Expand Down Expand Up @@ -245,8 +241,6 @@ struct graph_properties_t {

namespace detail {

using namespace cugraph::visitors;

// use (key, value) pairs to store source/destination properties if (unique edge
// sources/destinations) over (V / row_comm_size|col_comm_size) is smaller than the threshold value
double constexpr edge_partition_src_dst_property_values_kv_pair_fill_ratio_threshold = 0.1;
Expand All @@ -261,9 +255,9 @@ size_t constexpr num_sparse_segments_per_vertex_partition{3};

// Common for both graph_view_t & graph_t and both single-GPU & multi-GPU versions
template <typename vertex_t, typename edge_t>
class graph_base_t : public graph_envelope_t::base_graph_t /*<- visitor logic*/ {
class graph_base_t {
public:
graph_base_t() = default; // Note: required by visitor logic
graph_base_t() = default;

graph_base_t(raft::handle_t const& handle,
vertex_t number_of_vertices,
Expand Down Expand Up @@ -292,11 +286,6 @@ class graph_base_t : public graph_envelope_t::base_graph_t /*<- visitor logic*/
bool is_symmetric() const { return properties_.is_symmetric; }
bool is_multigraph() const { return properties_.is_multigraph; }

void apply(visitor_t& v) const override // <- visitor logic
{
v.visit_graph(*this);
}

protected:
raft::handle_t const* handle_ptr() const { return handle_ptr_; };
graph_properties_t graph_properties() const { return properties_; }
Expand Down
86 changes: 0 additions & 86 deletions cpp/include/cugraph/visitors/enum_mapping.hpp

This file was deleted.

74 changes: 0 additions & 74 deletions cpp/include/cugraph/visitors/erased_pack.hpp

This file was deleted.

26 changes: 0 additions & 26 deletions cpp/include/cugraph/visitors/graph_enum.hpp

This file was deleted.

Loading

0 comments on commit b50850f

Please sign in to comment.