Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] initial pylibcugraph support #1782

Closed
9 tasks done
rlratzel opened this issue Aug 19, 2021 · 1 comment · Fixed by #1800 or #1853
Closed
9 tasks done

[FEA] initial pylibcugraph support #1782

rlratzel opened this issue Aug 19, 2021 · 1 comment · Fixed by #1800 or #1853
Assignees
@rlratzel @Iroy30
Labels
improvement Improvement / enhancement to an existing function
Milestone
21.10

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Aug 19, 2021 •
edited
Loading

  • Make initial source tree changes (change python dir to have cugraph and pylibcugraph subdirs, move setup.py-related files, etc.)
  • Update top-level build.sh script to add pylibcugraph as an optional target
  • Add initial test (python/pylibcugraph/pylibcugraph/tests) that just tests that import pylibcugraph works
  • Update ci/gpu/build.sh and ci/test.sh to include pylibcugraph build and test
  • Add conda recipe for pylibcugraph, do test build and install and ensure import pylibcugraph works
  • Contact Ops team about these changes
  • Contact CuPy team about these changes
  • Add support for WCC algo to pylibcugraph
  • Update test to import and call WCC
@rlratzel rlratzel added the ? - Needs Triage Need team to review and classify label Aug 19, 2021
@rlratzel rlratzel added this to the 21.10 milestone Aug 19, 2021
@rlratzel
Copy link
Contributor Author

Updated original cugraph/CuPy RFC with proposal to use pylibcugraph here.

@rlratzel rlratzel mentioned this issue Aug 24, 2021
Merged
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function and removed ? - Needs Triage Need team to review and classify labels Aug 27, 2021
rapids-bot bot pushed a commit that referenced this issue Aug 27, 2021
@rlratzel
Initial version of pylibcugraph source tree and build script updates (
64a1622 
#1787)

Initial version of `pylibcugraph` source tree and build script updates plus connected_components placeholder.

Part of #1782 

Tested by running the new tests part of this PR.  Also manually tested by building `pylibcugraph` importing it interactively, and confirming `pylibcugraph.weakly_connected_components` raise `NotImplementedError`

Note: there is likely still some cleanup to do in the various setup files, since those were copied as-is from cugraph and modified only to work with `pylibcugraph` dir names.

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Joseph Nke (https://github.com/jnke2016)
  - Brad Rees (https://github.com/BradReesWork)
  - https://github.com/Iroy30
  - Ray Douglass (https://github.com/raydouglass)

URL: #1787
@rlratzel rlratzel linked a pull request Sep 2, 2021 that will close this issue
[REVIEW] Pylibcugraph connected components #1800
Merged
@rapids-bot rapids-bot bot closed this as completed in #1800 Sep 3, 2021
@rlratzel rlratzel mentioned this issue Sep 28, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 28, 2021
@rlratzel
Removed NetworkX requirement for type checks, fixed docstring, added …
1397f6c 
…new docstrings, import cleanups (#1853)

* Changed type check code to no longer require NetworkX and instead only check Nx types if installed. #1851
* Cleaned up imports, removed unused imports.
* Changed `import_optional` to use `importlib` instead, and return `MissingModule` instances for easier error reporting.
* Fixed format of example in `rmat` docstring #1807
* Added docstrings for `pylibcugraph` `*_connected_components` APIs. #1782 

Tested changes to optional import and type checking code by uninstalling `NetworkX`, observing the failure shown in #1851, applying change, then testing to observe the same script runs to completion without Nx installed.

closes #1851 
closes #1807 
closes #1782

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Joseph Nke (https://github.com/jnke2016)

URL: #1853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlratzel rlratzel

@Iroy30 Iroy30

Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
21.10
3 participants
@rlratzel @BradReesWork @Iroy30