Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Expose count_multi_edges for cuGraph C++ graph_view_t to python #2417

Closed
Tracked by #3280
VibhuJawa opened this issue Jul 15, 2022 · 0 comments · Fixed by #4426
Closed
Tracked by #3280

[FEA] Expose count_multi_edges for cuGraph C++ graph_view_t to python #2417

VibhuJawa opened this issue Jul 15, 2022 · 0 comments · Fixed by #4426
Labels
feature request New feature or request

Comments

@VibhuJawa
Copy link
Member

Describe the solution you'd like and any additional context

We should expose count_multi_edges for cuGraph C++ graph_view_t to python to check if a graph has multi_edges.

It is possible for that it can be used to has_duplicates in Property Graphs.
Currently we do expensive has_duplicates call here and using that count_multi_edges might be more optimial.

For more context see discussion here

@VibhuJawa VibhuJawa added the ? - Needs Triage Need team to review and classify label Jul 15, 2022
@BradReesWork BradReesWork added the feature request New feature or request label Jan 12, 2023
@BradReesWork BradReesWork modified the milestone: 23.02 Jan 12, 2023
@rapidsai rapidsai deleted a comment from github-actions bot May 2, 2023
@rapidsai rapidsai deleted a comment from github-actions bot May 2, 2023
@VibhuJawa VibhuJawa removed their assignment Jan 2, 2024
rapids-bot bot pushed a commit that referenced this issue May 17, 2024
…4426)

Python property graph class does some expensive dask calls to determine if a graph is a multi-graph.

This PR exposes to the C API and the PLC layer the graph_view method that counts the number of multi-edges in the graph.  Specifically, the function returns the number of extra edges exist.  So if the edge `(u,v)` exists `k` times, that edge contributes `k-1` to the return value.

If the return value of this function is greater than 0 then the graph is a multi-graph.  If the return value is 0 then while the graph might be labeled a multi-graph, there are no multi-edges so it could be treated as a graph.

Closes #2417 

Note that the property graph python code would still need to be modified to use this function.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Joseph Nke (https://github.com/jnke2016)
  - Alex Barghi (https://github.com/alexbarghi-nv)

URL: #4426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants