Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Experimental Triangle count errors out when no weights are provided #2615

Closed
acostadon opened this issue Aug 24, 2022 · 0 comments · Fixed by #2716
Closed

[FIX] Experimental Triangle count errors out when no weights are provided #2615

acostadon opened this issue Aug 24, 2022 · 0 comments · Fixed by #2716
Assignees
@acostadon
Milestone
22.10

Comments

@acostadon
Copy link
Contributor

Describe the bug
Experimental Triangle count on line 92 creates a variable out of he dataframe weights column and fails if it is not present.

Steps/Code to reproduce bug
Run triangle_count with any graph that does not have weights

Expected behavior
Since the algo does not use weights, providing a default weight column when one is not present will allow the algorithm to correctly complete.

Environment overview (please complete the following information)
Any

  • Method of cuGraph install: Any
  • If method of install is [Docker], provide docker pull & docker run commands used
@acostadon acostadon added bug Something isn't working ? - Needs Triage Need team to review and classify labels Aug 24, 2022
@acostadon acostadon self-assigned this Aug 25, 2022
@acostadon acostadon added Fix and removed bug Something isn't working ? - Needs Triage Need team to review and classify labels Aug 25, 2022
@acostadon acostadon added this to the 22.10 milestone Aug 25, 2022
@acostadon acostadon changed the title [BUG] Experimental Triangle count errors out when no weights are provided [FIX] Experimental Triangle count errors out when no weights are provided Aug 25, 2022
@acostadon acostadon mentioned this issue Aug 28, 2022
Closed
@acostadon acostadon mentioned this issue Sep 22, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 23, 2022
@acostadon
added tests for triangle count on unweighted graphs and graphs with i…
58477c5 
…nt64 vertex types (#2716)

closes #2615
closes #2616

replaces #2626 which was closed

Authors:
  - Don Acosta (https://github.com/acostadon)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acostadon acostadon

Labels
None yet
Projects
None yet
Milestone
22.10
1 participant
@acostadon