Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose threshold parameter in Louvain for nx compatibility #3791

Closed
ChuckHastings opened this issue Aug 14, 2023 · 0 comments · Fixed by #3792
Closed

Expose threshold parameter in Louvain for nx compatibility #3791

ChuckHastings opened this issue Aug 14, 2023 · 0 comments · Fixed by #3792
Assignees
@ChuckHastings

Comments

@ChuckHastings
Copy link
Collaborator

ChuckHastings commented Aug 14, 2023 •
edited
Loading

The threshold parameter is exposed in the nx Louvain implementation. We should expose this parameter through the C++ and C API.

This will provide the C API and C++ work to support #3700
@ChuckHastings ChuckHastings self-assigned this Aug 14, 2023
@ChuckHastings ChuckHastings mentioned this issue Aug 15, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #3792 Sep 6, 2023
rapids-bot bot pushed a commit that referenced this issue Sep 6, 2023
@ChuckHastings
Expose threshold in louvain (#3792)
98324ac 
The threshold parameter (referred to as `epsilon` in most of the centrality measures) is used to define when to stop the iterative steps of Louvain.  Once the modularity increase for an iteration of Louvain is smaller than the threshold we will stop that iteration and start coarsening the graph.

This parameter was hard-coded in the initial C++ implementation of Louvain.  This PR exposes this parameter through the C++, C API, PLC and Python layers.

The PR also renames the python parameter `max_iter` to be `max_level`, which is more appropriate semantically.

Closes #3791

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Naim (https://github.com/naimnv)
  - Joseph Nke (https://github.com/jnke2016)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3792
rlratzel pushed a commit to rlratzel/cugraph that referenced this issue Sep 8, 2023
@ChuckHastings @rlratzel
Expose threshold in louvain (rapidsai#3792)
5574eb6 
The threshold parameter (referred to as `epsilon` in most of the centrality measures) is used to define when to stop the iterative steps of Louvain.  Once the modularity increase for an iteration of Louvain is smaller than the threshold we will stop that iteration and start coarsening the graph.

This parameter was hard-coded in the initial C++ implementation of Louvain.  This PR exposes this parameter through the C++, C API, PLC and Python layers.

The PR also renames the python parameter `max_iter` to be `max_level`, which is more appropriate semantically.

Closes rapidsai#3791

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Naim (https://github.com/naimnv)
  - Joseph Nke (https://github.com/jnke2016)
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#3792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChuckHastings ChuckHastings

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose threshold in louvain ChuckHastings/cugraph
1 participant
@ChuckHastings