Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] cuGraph-PyG BulkSampleLoader Doesn't Handle Directories Correctly #3959

Closed
alexbarghi-nv opened this issue Oct 29, 2023 · 0 comments · Fixed by #3978
Closed

[BUG] cuGraph-PyG BulkSampleLoader Doesn't Handle Directories Correctly #3959

alexbarghi-nv opened this issue Oct 29, 2023 · 0 comments · Fixed by #3978
Assignees
@alexbarghi-nv
Labels
CRITICAL BUG! BUG that needs to be FIX NOW !!!!
Milestone
23.12

Comments

@alexbarghi-nv
Copy link
Member

alexbarghi-nv commented Oct 29, 2023 •
edited
Loading

Currently, the BulkSampleLoader incorrectly creates a new temporary directory instead of directly writing the files to the path given. This makes it nearly impossible to use it within multi-GPU offline workflows since they require that all files be written to the same top-level directory.
@alexbarghi-nv alexbarghi-nv added the CRITICAL BUG! BUG that needs to be FIX NOW !!!! label Oct 29, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.12 milestone Oct 29, 2023
@alexbarghi-nv alexbarghi-nv self-assigned this Oct 29, 2023
@alexbarghi-nv alexbarghi-nv mentioned this issue Nov 6, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Nov 17, 2023
@alexbarghi-nv
[BUG] Fix Incorrect Edge Index, Directory Selection in cuGraph-PyG Lo…
119816c 
…ader (#3978)

Fixes three major bugs:
1. Edge index is set to [dst, dst] instead of [dst, src] in some cases
2. The sample directory is always set to a new temporary directory rather than the path given
3. The version of `pylibcugraphops` in `meta.yaml` is wrong and causes the wrong packages to be resolved

This PR also simplifies `ci/test_python.sh` by doing only a single conda install when creating the `test_cugraph_pyg` environment.

Closes #3959

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Naim (https://github.com/naimnv)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Ray Douglass (https://github.com/raydouglass)

URL: #3978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
CRITICAL BUG! BUG that needs to be FIX NOW !!!!
Projects
None yet
Milestone
23.12
Development

Successfully merging a pull request may close this issue.

[BUG] Fix Incorrect Edge Index, Directory Selection in cuGraph-PyG Loader alexbarghi-nv/cugraph
1 participant
@alexbarghi-nv