Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Update cuGraph to always explicitly specify RMM pool size and avoid using rmm::detail APIs #4066

Closed
2 tasks done
Tracked by #10
harrism opened this issue Dec 20, 2023 · 0 comments · Fixed by #4086
Closed
2 tasks done
Tracked by #10
Assignees
Labels
bug Something isn't working

Comments

@harrism
Copy link
Member

harrism commented Dec 20, 2023

rapidsai/rmm#1417 and followon PRs make a number of improvements and changes to help consumers of RMM avoid accessing RMM's detail namespace.

initial pool size in pool_memory_resource is required to be provided (no longer optional)
rmm::detail::available_device_memory() (moving to `rmm::available_device_memory())
Move alignment utility functions out of detail namespace.
Add utility to calculate an aligned percentage of free device memory in bytes. This way, existing instantiations of pool_memory_resource(upstream) can be replaced by pool_memory_resource(upstream, rmm::percent_of_free_device_memory(50), which matches previous behavior.

cuGraph should be updated for these changes once rapidsai/rmm#1417 is merged. I have a PR ready to open.

Version

24.02

Which installation method(s) does this occur on?

Source

Describe the bug.

cuGraph calls RMM detail APIs, namely this one, which is going away (it's becoming a public API, but still this is a great example of what not to do).

auto const [free, total] = rmm::detail::available_device_memory();

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow cuGraph's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@harrism harrism added bug Something isn't working ? - Needs Triage Need team to review and classify labels Dec 20, 2023
@harrism harrism self-assigned this Jan 11, 2024
@harrism harrism changed the title [BUG]: cuGRAPH should not call RMM detail APIs [BUG]: Update cuGraph to always explicitly specify RMM pool size and avoid using rmm::detail APIs Jan 11, 2024
@harrism harrism removed the ? - Needs Triage Need team to review and classify label Jan 11, 2024
rapids-bot bot pushed a commit that referenced this issue Jan 17, 2024
This PR fixes up cuGraph to avoid usage that will soon be deprecated in RMM.

Depends on rapidsai/rmm#1417

Fixes #4066

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #4086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant