Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Enhance compile time #1267

Merged
merged 17 commits into from
Nov 23, 2020
Merged

[REVIEW] Enhance compile time #1267

merged 17 commits into from
Nov 23, 2020

Conversation

aschaffer
Copy link
Collaborator

Look into alternative ways to instantiate templates to improve compilation time.

@aschaffer aschaffer requested a review from a team as a code owner November 12, 2020 00:02
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov-io
Copy link

codecov-io commented Nov 12, 2020 •
edited
Loading

Codecov Report

Merging #1267 (e283aa2) into branch-0.17 (1be056b) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #1267      +/-   ##
===============================================
+ Coverage        57.84%   57.92%   +0.08%     
===============================================
  Files               63       65       +2     
  Lines             2780     2800      +20     
===============================================
+ Hits              1608     1622      +14     
- Misses            1172     1178       +6
Impacted Files Coverage Δ
python/cugraph/layout/force_atlas2.py 52.94% <0.00%> (-7.06%) ⬇️
python/cugraph/cores/k_core.py 85.71% <0.00%> (-1.79%) ⬇️
python/cugraph/__init__.py 100.00% <0.00%> (ø)
python/cugraph/dask/link_analysis/pagerank.py 25.80% <0.00%> (ø)
python/cugraph/linear_assignment/lap.py 77.77% <0.00%> (ø)
python/cugraph/linear_assignment/__init__.py 100.00% <0.00%> (ø)
python/cugraph/structure/number_map.py 55.95% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be056b...e283aa2. Read the comment docs.

@BradReesWork BradReesWork added the improvement Improvement / enhancement to an existing function label Nov 13, 2020
@BradReesWork BradReesWork added this to the 0.17 milestone Nov 13, 2020
@aschaffer aschaffer requested a review from a team as a code owner November 19, 2020 23:59
@aschaffer aschaffer requested a review from a team as a code owner November 20, 2020 00:04
rlratzel
rlratzel requested changes Nov 20, 2020
View reviewed changes
cpp/CMakeLists.txt Show resolved Hide resolved
build.sh Show resolved Hide resolved
@aschaffer
Copy link
Collaborator Author

Rerun tests.

ChuckHastings
ChuckHastings requested changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I think we should consider excluding. Otherwise I can't wait to have this merged.

cpp/include/experimental/eidecl_graph.hpp Show resolved Hide resolved
cpp/include/eidecl_graph.hpp Show resolved Hide resolved
cpp/include/eidir_graph.hpp Outdated Show resolved Hide resolved
cpp/include/graph.hpp Show resolved Hide resolved
cpp/src/community/louvain.cu Show resolved Hide resolved
@aschaffer aschaffer changed the title [WIP] Enhance compile time [REVIEW] Enhance compile time Nov 23, 2020
@BradReesWork BradReesWork linked an issue Nov 23, 2020 that may be closed by this pull request
[ENH] Reduce compile time #1219
Closed
5 tasks
@BradReesWork BradReesWork merged commit 1952767 into rapidsai:branch-0.17 Nov 23, 2020
@ajschmidt8 ajschmidt8 mentioned this pull request Nov 24, 2020
Merged
@aschaffer aschaffer deleted the enh_ext_compile_time_017 branch May 6, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@aschaffer aschaffer

Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

[ENH] Reduce compile time
7 participants
@aschaffer @GPUtester @codecov-io @rlratzel @ajschmidt8 @BradReesWork @ChuckHastings