[REVIEW] FEA SciPy sparse matrix input support for WCC, SCC, SSSP, and BFS #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scipyinputsupport
rlratzel
added
2 - In Progress
improvement
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #1277 +/- ##
===============================================
+ Coverage 58.51% 60.07% +1.56%
===============================================
Files 67 67
Lines 2883 3006 +123
===============================================
+ Hits 1687 1806 +119
- Misses 1196 1200 +4
Continue to review full report at Codecov.
|
rlratzel
commented
Nov 23, 2020
…scipyinputsupport
BradReesWork
approved these changes
Nov 24, 2020
…nd updates to support better build-all behavior with flags and optional non-default build dirs.
rlratzel
changed the title
rlratzel
changed the title
…scipyinputsupport
|
rerun tests |
1 similar comment
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for SciPy sparse matrix inputs to WCC, SCC, SSSP, and BFS. This PR also adds APIs which allow cugraph to be used as a drop-in replacement for the corresponding SciPy sparse graph routines here. This compatibility extends to adding new optional parameters which are handled based on the input type (Graph obj or matrix) and the specific algo.
Additional refactorings were done to utilities to make the various input/output checking more reusable and compact, as well as a utility to clean up how optional dependencies are imported.