Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] add self loop check variable #1279

Merged
merged 3 commits into from
Nov 30, 2020
Merged

[REVIEW] add self loop check variable #1279

merged 3 commits into from
Nov 30, 2020

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Nov 24, 2020 •
edited
Loading

close #536

@Iroy30 Iroy30 requested a review from a team as a code owner November 24, 2020 15:47
@Iroy30 Iroy30 changed the title [REVIRadd self loop check variable [REVIEW] Radd self loop check variable Nov 24, 2020
@Iroy30 Iroy30 changed the title [REVIEW] Radd self loop check variable [REVIEW] add self loop check variable Nov 24, 2020
afender
afender approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please add close #536 in the descritpion.

@codecov-io
Copy link

codecov-io commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #1279 (ec24af8) into branch-0.17 (76a026f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #1279      +/-   ##
===============================================
- Coverage        58.05%   57.97%   -0.09%     
===============================================
  Files               65       65              
  Lines             2837     2803      -34     
===============================================
- Hits              1647     1625      -22     
+ Misses            1190     1178      -12
Impacted Files Coverage Δ
python/cugraph/structure/graph.py 66.79% <100.00%> (+0.19%) ⬆️
python/cugraph/__init__.py 100.00% <0.00%> (ø)
python/cugraph/structure/__init__.py 100.00% <0.00%> (ø)
python/cugraph/structure/convert_matrix.py 83.01% <0.00%> (+6.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a026f...dc6b6fc. Read the comment docs.

@BradReesWork BradReesWork added the feature request New feature or request label Nov 24, 2020
@BradReesWork BradReesWork added this to the 0.17 milestone Nov 24, 2020
@BradReesWork BradReesWork merged commit b98175e into rapidsai:branch-0.17 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

[FEA] self loop check
4 participants
@Iroy30 @codecov-io @afender @BradReesWork