[REVIEW] Updated cuxfilter to 0.18, removed datashader indirect dependency in conda dev .yml files #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead pulled in via cuxfilter.
afender
added
6 - Okay to Auto-Merge
bug
hlinsen
approved these changes
Dec 10, 2020
hlinsen
approved these changes
Dec 10, 2020
rlratzel
changed the title
rlratzel
changed the title
rlratzel
changed the title
seunghwak
approved these changes
Dec 10, 2020
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1311 +/- ##
============================================
Coverage 60.38% 60.38%
============================================
Files 67 67
Lines 3029 3029
============================================
Hits 1829 1829
Misses 1200 1200
Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
Dec 11, 2020
raydouglass
reviewed
Dec 15, 2020
afender
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Looks good but agreed with Ray that https://github.com/rapidsai/cugraph/blob/branch-0.18/ci/release/update-version.sh should be upgraded for automation.
… that has a side effect of moving device data, and if this is called after pointer values are assigned to pass to C++, the C++ code will not get the correct pointers. This is a cudf bug and they have already been notified.
afender
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated cuxfilter to 0.18 and removed datashader indirect dependency in cugraph conda dev environment files.