Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MG WCC improvements #1628

Merged
merged 11 commits into from
Jun 4, 2021
Merged

MG WCC improvements #1628

merged 11 commits into from
Jun 4, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented May 26, 2021 •
edited
Loading

Should be merged after PR #1636.

  • Undo NCCL 2.9.6 bug workarounds.
  • MG WCC weak scaling improvements.

@seunghwak seunghwak requested a review from a team as a code owner May 26, 2021 14:43
@seunghwak seunghwak added 2 - In Progress DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 26, 2021
@BradReesWork BradReesWork added this to the 21.06 milestone May 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@637c139). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 20310de differs from pull request most recent head 571ff42. Consider uploading reports for the commit 571ff42 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #1628   +/-   ##
===============================================
  Coverage                ?   59.79%           
===============================================
  Files                   ?       80           
  Lines                   ?     3542           
  Branches                ?        0           
===============================================
  Hits                    ?     2118           
  Misses                  ?     1424           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637c139...571ff42. Read the comment docs.

@seunghwak seunghwak changed the title [WIP] MG WCC improvements MG WCC improvements Jun 1, 2021
@seunghwak seunghwak added 3 - Ready for Review and removed 2 - In Progress DO NOT MERGE Hold off on merging; see PR for details labels Jun 1, 2021
@BradReesWork BradReesWork linked an issue Jun 2, 2021 that may be closed by this pull request
[FEA] MNMG WCC #1467
Closed
@seunghwak
Copy link
Contributor Author

rerun tests

1 similar comment
@rlratzel
Copy link
Contributor

rlratzel commented Jun 3, 2021

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@BradReesWork
Copy link
Member

rerun tests

@seunghwak
Copy link
Contributor Author

rerun tests

1 similar comment
@ajschmidt8
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

Rerun tests

@rlratzel
(temporarily) disabling cugraph.tests.test_force_atlas2.test_force_at…
bf11640 
…las2_multi_column_pos_list due to non-deterministic results.
@rlratzel
flake8 fix
571ff42
@seunghwak seunghwak requested a review from a team as a code owner June 4, 2021 01:48
rlratzel
rlratzel approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning: I'm approving my own py test update.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ed0e3a2 into rapidsai:branch-21.06 Jun 4, 2021
@seunghwak seunghwak deleted the enh_mg_wcc_tuning branch June 24, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@aschaffer aschaffer aschaffer approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.06
Development

Successfully merging this pull request may close these issues.

[FEA] MNMG WCC
7 participants
@seunghwak @codecov-commenter @rlratzel @BradReesWork @ajschmidt8 @aschaffer @ChuckHastings