Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Cascaded dispatch for type-erased API #1711

Merged
merged 31 commits into from
Jul 20, 2021

Conversation

aschaffer
Copy link
Collaborator

This enhancement PR provides the C++ infrastructure for a type-erased API to be exposed to C-only, Cython, and potentially other glue languages. This will be the first in a series of such API PRs to expose cugraph functionality to other languages.

aschaffer and others added 26 commits November 30, 2020 15:00
Update forked branch-0.18 from release
Update branch-0.19 from release
update forked from release branch-0.19
Merge from release branch-0.19
Merge latest rapidsai:branch-0.19 into aschaffer:branch-0.19
merge latest release branch-0.20
Merge latest rapidsai/branch-0.20 into forked branch-0.20
aschaffer/21.08 <- rapidsai/21.08
Co-authored-by: Paul Taylor <paul.e.taylor@me.com>
@aschaffer aschaffer requested review from a team as code owners July 14, 2021 00:01
@rlratzel rlratzel added the improvement Improvement / enhancement to an existing function label Jul 14, 2021
@rlratzel rlratzel added the non-breaking Non-breaking change label Jul 14, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jul 14, 2021
cpp/CMakeLists.txt Show resolved Hide resolved
cpp/src/visitors/bfs_visitor.cu Outdated Show resolved Hide resolved
cpp/include/cugraph/visitors/bfs_visitor.hpp Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #1711 (170d92c) into branch-21.08 (9bcfa14) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1711      +/-   ##
================================================
+ Coverage         59.82%   59.85%   +0.02%     
================================================
  Files                77       77              
  Lines              3515     3517       +2     
================================================
+ Hits               2103     2105       +2     
  Misses             1412     1412              
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcfa14...170d92c. Read the comment docs.

@aschaffer
Copy link
Collaborator Author

rerun tests.

Copy link
Collaborator

@kaatish kaatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c8f3754 into rapidsai:branch-21.08 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants