Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MG_test bug #1718

Merged
merged 7 commits into from
Jul 22, 2021
Merged

Fix MG_test bug #1718

merged 7 commits into from
Jul 22, 2021

Conversation

jnke2016
Copy link
Contributor

Fix test_mg_batch_betweenness_centrality, test_mg_batch_edge_betweenness_centrality, test_mg_replication, test_mg_renumber

closes #1706
closes #1715
closes #1716

@jnke2016 jnke2016 requested a review from a team as a code owner July 16, 2021 17:42
@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 19, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jul 19, 2021
rlratzel
rlratzel reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had a few suggestions.

python/cugraph/dask/structure/replication.pyx Outdated Show resolved Hide resolved
python/cugraph/dask/structure/replication.pyx Outdated Show resolved Hide resolved
python/cugraph/dask/common/input_utils.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@7ad8fc3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1718   +/-   ##
===============================================
  Coverage                ?   59.75%           
===============================================
  Files                   ?       77           
  Lines                   ?     3523           
  Branches                ?        0           
===============================================
  Hits                    ?     2105           
  Misses                  ?     1418           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad8fc3...1c29775. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f3f67e8 into rapidsai:branch-21.08 Jul 22, 2021
@jnke2016 jnke2016 deleted the fix_mg_batch_bc branch September 24, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@Iroy30 Iroy30 Awaiting requested review from Iroy30

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.08
4 participants
@jnke2016 @codecov-commenter @BradReesWork @rlratzel