Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] revert cuco to latest dev branch, issues should be fixed #1721

Merged

Conversation

ChuckHastings
Copy link
Collaborator

We had an issue in CI that uncovered the fact that raft is referencing the dev branch of coco while cugraph has it pinned to a previous commit. CI is using the newer dev branch version, which doesn't match what happens when we do local builds.

The original motivation for pinning was a temporary fix because of a bug introduced in coco which has since been resolved. This PR reverts us back to using the dev branch.

@ChuckHastings ChuckHastings requested a review from a team as a code owner July 20, 2021 15:41
@ChuckHastings ChuckHastings self-assigned this Jul 20, 2021
@ChuckHastings ChuckHastings added this to the 21.08 milestone Jul 20, 2021
@ChuckHastings ChuckHastings added the bug Something isn't working label Jul 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #1721 (10d7467) into branch-21.08 (9bcfa14) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1721      +/-   ##
================================================
+ Coverage         59.82%   59.85%   +0.02%     
================================================
  Files                77       77              
  Lines              3515     3517       +2     
================================================
+ Hits               2103     2105       +2     
  Misses             1412     1412              
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcfa14...10d7467. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0708601 into rapidsai:branch-21.08 Jul 21, 2021
@ChuckHastings ChuckHastings deleted the bug_fix_cmake_to_match_raft branch July 29, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants