Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MG test bug #1897

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix MG test bug #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a07c0c
add check for num_edges==0 for sorting neighbor list
seunghwak Oct 20, 2021
3d03403
add dolphins.mtx to C++ MG louvain test
seunghwak Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cpp/src/structure/graph_impl.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,11 @@ void sort_adjacency_list(raft::handle_t const& handle,
// std::move(minors) & weights_ = std::move (weights). This affects peak memory use and we may
// find the presorting approach more attractive under this scenario.

// 1. We segmented sort edges in chunks, and we need to adjust chunk offsets as we need to sort
// 1. Check if there is anything to sort

if (num_edges == 0) { return; }

// 2. We segmented sort edges in chunks, and we need to adjust chunk offsets as we need to sort
// each vertex's neighbors at once.

// to limit memory footprint ((1 << 20) is a tuning parameter)
Expand Down Expand Up @@ -421,7 +425,7 @@ void sort_adjacency_list(raft::handle_t const& handle,
d_vertex_offsets.size(),
handle.get_stream());

// 2. Segmented sort each vertex's neighbors
// 3. Segmented sort each vertex's neighbors

size_t max_chunk_size{0};
for (size_t i = 0; i < num_chunks; ++i) {
Expand Down
5 changes: 2 additions & 3 deletions cpp/tests/community/mg_louvain_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,7 @@ TEST_P(Louvain_MG_Testfixture, CheckInt32Int32Float)
INSTANTIATE_TEST_SUITE_P(
simple_test,
Louvain_MG_Testfixture,
::testing::Values(Louvain_Usecase("test/datasets/karate.mtx", true, 100, 1)
//,Louvain_Usecase("test/datasets/smallworld.mtx", true, 100, 1)
));
::testing::Values(Louvain_Usecase("test/datasets/karate.mtx", true, 100, 1),
Louvain_Usecase("test/datasets/dolphins.mtx", true, 100, 1)));

CUGRAPH_MG_TEST_PROGRAM_MAIN()