Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable crosslink to rmm #1918

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Nov 1, 2021

This PR updates cpp/doxygen/Doxyfile to consume the generated Doxygen tags from rmm (see rapidsai/rmm#672). This will enable linking between the cugraph docs and rmm docs.

@AyodeAwe AyodeAwe requested review from a team as code owners November 1, 2021 09:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@731065f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1918   +/-   ##
===============================================
  Coverage                ?   70.13%           
===============================================
  Files                   ?      143           
  Lines                   ?     8812           
  Branches                ?        0           
===============================================
  Hits                    ?     6180           
  Misses                  ?     2632           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731065f...06fca84. Read the comment docs.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One change requested. Also please add a description to the PR describing the changes.

cpp/doxygen/Doxyfile Outdated Show resolved Hide resolved
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@ChuckHastings ChuckHastings added the doc Documentation label Nov 1, 2021
@AyodeAwe AyodeAwe merged commit 5465e22 into rapidsai:branch-21.12 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants