Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the update_frontier_v_push_if_out_nbr primitive & BFS performance #1988

Merged
merged 18 commits into from
Jan 10, 2022
Merged

Update the update_frontier_v_push_if_out_nbr primitive & BFS performance #1988

merged 18 commits into from
Jan 10, 2022

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Dec 10, 2021 •
edited
Loading

  • Updates update_frontier_v_push_if_out_nbr to use fewer atomics & reduce thread-divergence.
  • Update BFS code to reduce unnecessary pushes.

@seunghwak seunghwak added 2 - In Progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 10, 2021
@seunghwak seunghwak added this to the 22.02 milestone Dec 10, 2021
@seunghwak seunghwak self-assigned this Dec 10, 2021
@seunghwak seunghwak requested a review from a team as a code owner December 10, 2021 17:08
@seunghwak seunghwak changed the title [WIP][skip-ci] Update the update_frontier_v_push_if_out_nbr primitive & BFS performance Update the update_frontier_v_push_if_out_nbr primitive & BFS performance Dec 21, 2021
@seunghwak seunghwak added 3 - Ready for Review DO NOT MERGE Hold off on merging; see PR for details and removed 2 - In Progress labels Dec 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@ba0e2d2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #1988   +/-   ##
===============================================
  Coverage                ?   70.75%           
===============================================
  Files                   ?      142           
  Lines                   ?     8860           
  Branches                ?        0           
===============================================
  Hits                    ?     6269           
  Misses                  ?     2591           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0e2d2...0990958. Read the comment docs.

@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 4, 2022
@kaatish
Copy link
Collaborator

kaatish commented Jan 5, 2022

Is there any information about the performance gains you have achieved with this PR?

@seunghwak
Copy link
Contributor Author

Is there any information about the performance gains you have achieved with this PR?

Yes, on GA102 (single GPU)

R-mat scale=26 edge_factor=16
239 ms => 35 ms
ljournal-2008
19 ms => 9 ms

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6883cc1 into rapidsai:branch-22.02 Jan 10, 2022
@seunghwak seunghwak deleted the enh_bfs_perf branch January 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaatish kaatish kaatish approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@seunghwak seunghwak

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.02
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @codecov-commenter @kaatish @ChuckHastings