Update C++ SG and MG Louvain tests to support Rmat and benchmark tests #2054
Conversation
ChuckHastings
added
3 - Ready for Review
improvement
ChuckHastings
changed the title
| @@ -29,7 +29,8 @@ | |||
| #include <vector> | |||
|
|
|||
| struct Louvain_Usecase { | |||
| bool test_weighted_{false}; | |||
There was a problem hiding this comment.
So, are we always testing for weighted graphs only?
There was a problem hiding this comment.
Yes. Louvain requires a weighted graph. All of the computations operate on the edge weights.
I'll add a CUGRAPH_EXPECTS in the algorithm implementation to check this, since we don't currently check that.
There was a problem hiding this comment.
Can't we implicitly assume edge weights of 1 if the input graph is unweighted? Or no real use case for this?
There was a problem hiding this comment.
I assume finding communities in unweighted graphs to be something practical.
There was a problem hiding this comment.
The python layer will add a weight of 1 for edges if the input graph is unweighted.
I think it would make the C++ code unwieldy to allow the input graph to be unweighted. Once we coarsen the graph it must be weighted, so we'd end up having to have different code paths for the original graph than from the coarsened graphs.
There was a problem hiding this comment.
Gotcha, just wanted to point out that there is memory requirement vs implementation complexity trade-off.
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2054 +/- ##
===============================================
Coverage ? 73.08%
===============================================
Files ? 151
Lines ? 9827
Branches ? 0
===============================================
Hits ? 7182
Misses ? 2645
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Some general cleanup of C++ Louvain tests.