-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conda to build python packages during GPU tests #2230
Use conda to build python packages during GPU tests #2230
Conversation
3e2224d
to
eb6211d
Compare
rerun tests |
eb6211d
to
bcd8dd0
Compare
rerun tests |
bcd8dd0
to
117a098
Compare
117a098
to
73d2239
Compare
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2230 +/- ##
================================================
- Coverage 70.82% 64.15% -6.67%
================================================
Files 170 99 -71
Lines 11036 4408 -6628
================================================
- Hits 7816 2828 -4988
+ Misses 3220 1580 -1640
Continue to review full report at Codecov.
|
dd07e4f
to
2a069a7
Compare
rerun tests |
93a3d4d
to
dccbc3f
Compare
d4e4672
to
a87fe2e
Compare
a87fe2e
to
2d133bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes look okay, but I did see a few that could cause problems which I commented on below. I also don't understand why some of these changes are needed for allowing the GPU tests to use a conda install instead of a from-source build (eg. why can't we continue to have a cugraph.tests
package? Why do we need a separate cugraph.testing
package?, etc.). Maybe we can chat offline about it and then update the PR or report back here, if necessary?
# As tests directory is not a module, we need to add it to the path | ||
sys.path.insert(0, '../') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things:
- this does not add the tests directory to the import path, it adds
..
, which will be interpreted as the parent directory of the CWD from where pytest is run. - pytest automatically adds the directories containing the collected test modules to the import path, so this may be "accidentally" working because of that
- these changes are not being tested by CI since our test script skips everything in the
mg
directory, so have you manually tested these changes on a multi-GPU machine to ensure they work? - needing to modify sys.path directly could be a symptom that we have a broken package hierarchy or some other code smell - is there a reason this directory is no longer a package (ie. had its
__init__.py
file removed)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ethyling based on our conversation, would you mind removing the sys.path.insert()
calls and adding a FIXME
stating that those tests need to be refactored to not import other tests and should instead put shared test code in a util module? Same for the other comment below.
# As tests directory is not a module, we need to add it to the path | ||
sys.path.insert(0, '.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same feedback as above)
@Ethyling and I just had a call about this and we agreed on the following:
|
2d133bb
to
4d7226a
Compare
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
4d7226a
to
79614ed
Compare
@gpucibot merge |
This PR convert the
from sources
build we are doing in GPU test job to aconda build
. This is done for the following reasons:conda
compilers andmamba
to build RAPIDS packagesThis may increase the global pipeline time, but the usage of
mamba
should resolve this asmamba
is faster thanconda
to build packages