Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangle Counting #2253

Merged
merged 39 commits into from
May 17, 2022
Merged

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Apr 28, 2022

Implements SG & MG Triangle Counting.

@seunghwak seunghwak added feature request New feature or request 2 - In Progress non-breaking Non-breaking change labels Apr 28, 2022
@seunghwak seunghwak self-assigned this Apr 28, 2022
@BradReesWork BradReesWork added this to the 22.06 milestone May 5, 2022
@seunghwak seunghwak changed the title [skip-ci] Triangle Counting Triangle Counting May 14, 2022
@seunghwak seunghwak added 3 - Ready for Review DO NOT MERGE Hold off on merging; see PR for details and removed 2 - In Progress labels May 14, 2022
@seunghwak seunghwak marked this pull request as ready for review May 14, 2022 00:36
@seunghwak seunghwak requested review from a team as code owners May 14, 2022 00:36
@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label May 16, 2022
@@ -0,0 +1,492 @@
/*
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be just 2022

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (tests/community/triangle_count_test.cpp & mg_triangle_count_test.cpp as well).

rapids-bot bot pushed a commit that referenced this pull request May 16, 2022
This defines the C API for triangle counting.

This PR is independent of #2253 and can be merged independently.  The change here defines the C API and returns the `CUGRAPH_NOT_IMPLEMENTED` error when called.  Once #2253 is completed and merged, a follow-up PR will fill in the C API implementation for triangle counting (although the code is written and untested in this PR).

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2271
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #2253 (2c900c0) into branch-22.06 (4a6263a) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.06    #2253   +/-   ##
=============================================
  Coverage         63.97%   63.97%           
=============================================
  Files               100      100           
  Lines              4436     4436           
=============================================
  Hits               2838     2838           
  Misses             1598     1598           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6263a...2c900c0. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a908ccd into rapidsai:branch-22.06 May 17, 2022
@seunghwak seunghwak deleted the fea_nbr_intersect branch August 11, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants