Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Eigenvector Centrality to pylibcugraph, cugraph APIs #2255

Merged
merged 63 commits into from
May 27, 2022
Merged

Add Eigenvector Centrality to pylibcugraph, cugraph APIs #2255

merged 63 commits into from
May 27, 2022

Conversation

betochimas
Copy link
Contributor

@betochimas betochimas commented Apr 28, 2022 •
edited
Loading

This PR:

  1. Adds Eigenvector Centrality to the pylibcugraph and cugraph software stacks, which started from Define C API for eigenvector centrality #2180 and is followed up by future PRs in order to close [ENH] Eigenvector Centrality #2146
  2. Minor improvements to pylibcugraph Katz Centrality
  3. Added functionality to test_doctests.py so that certain docstrings can be skipped on different architecture configs (such as ktruss in CUDA 11.4)
  4. Added undirected/directed versions of graph example used in C tests in datasets
  5. Removed cugraph copy of warning wrapper from pylibcugraph and have it call the pylibcugraph version
  6. Testing for both Python eigenvector centrality wrappers

This PR is identical to #2243, just that the name of the branch is different

ChuckHastings and others added 30 commits March 30, 2022 18:17
@ChuckHastings
Define eigenvector centrality C API, define tests
07684ed
@ChuckHastings
fix clang-format issues
17be3fe
@ChuckHastings
respond to PR comments
6d828e1
@ChuckHastings
update pylibcugraph to use new C API changes
f23e2b5
@ChuckHastings
add katz centrality to the C API
ea32dc8
@betochimas
Merge pull request #38 from ChuckHastings/fea_c_api_katz
ab7add0 
Fea c api katz
@ChuckHastings
Merge branch 'branch-22.06' into fea_c_api_katz
9c64e58
@betochimas
Incorporated C katz test to pylib
d295448
@betochimas
Merge branch 'branch-22.06-wip-sg-katz' into merge-4_6
770e20c
@betochimas
Merge pull request #41 from betochimas/merge-4_6
391afa5 
Merging 22.06 branch into wip sg katz branch
@betochimas
Merge pull request #40 from ChuckHastings/fea_c_api_katz
24c2d39 
Fea c api katz
@betochimas
Split algorithms.pxd into 2, similar to libcugraph_c
316f0a6
@betochimas
Merge pull request #42 from betochimas/branch-22.06
be762a7 
Include PR#2124
@betochimas
Implementation of katz_centrality on pylib, testing close there
dfe6da2
@betochimas
Merge branch 'branch-22.06-wip-sg-katz' of https://github.com/betochi…
3d0a3bb 
…mas/cugraph into branch-22.06-wip-sg-katz
@betochimas
Initial commit for cugraph level refactor of SG Katz
e8de135
@betochimas
Style check edits
fd31c36
@betochimas
Merge pull request #43 from rapidsai/branch-22.06
b9b72f8 
Merging 4/7-11 commits
@betochimas
Revert "Merging 4/7-11 commits"
7d0182b
@betochimas
Merge pull request #44 from betochimas/revert-43-branch-22.06
6e0cba2 
Revert "Merging 4/7-11 commits"
@betochimas
Sorting results if renumbered
4a7673a
@betochimas
Revert "Revert "Merging 4/7-11 commits""
4e88aa8
@betochimas
Merge pull request #45 from betochimas/revert-44-revert-43-branch-22.06
5ee1623 
Revert "Revert "Merging 4/7-11 commits""
@betochimas
Merge pull request #46 from betochimas/branch-22.06
6c8c6a8 
Fix error from two conflicting merges (rapidsai#2219)
@betochimas
Testing edits
c22be7a
@betochimas
Modify refactored sg katz to prevent breaking functionality/compat wi…
0e7f8b7 
…th old katz
@betochimas
Removed old SG Katz, ensured that refactored Katz passes original tes…
0de6782 
…t suite, minor edits
@betochimas
Add descriptions to new katz wrappers
cdefe85
@betochimas
Merge pull request #47 from betochimas/branch-22.06
146bf63 
Merging in 22.06 branch w/ sg katz branch for eigen
@betochimas
Initial pylib wrapper, waiting on eigen C implementation
85279af
@ChuckHastings
Copy link
Collaborator

C API and C++ implementation for Eigenvector Centrality have been merged, which should unblock progress on this.

@betochimas betochimas marked this pull request as ready for review May 24, 2022 20:46
@betochimas betochimas requested a review from a team as a code owner May 24, 2022 20:46
rlratzel
rlratzel requested changes May 26, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had a request for promoting some of the newer pylibcugraph APIs a bit earlier than we normally do, but in this case I think it's appropriate.

python/cugraph/cugraph/centrality/katz_centrality.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/dask/centrality/eigenvector_centrality.py Outdated Show resolved Hide resolved
python/pylibcugraph/pylibcugraph/experimental/__init__.py Outdated Show resolved Hide resolved
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6d0239d into rapidsai:branch-22.06 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv requested changes

@rlratzel rlratzel rlratzel approved these changes

@acostadon acostadon Awaiting requested review from acostadon

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.06
Development

Successfully merging this pull request may close these issues.

[ENH] Eigenvector Centrality
6 participants
@betochimas @codecov-commenter @ChuckHastings @BradReesWork @rlratzel @alexbarghi-nv