Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve inconsistencies in reduction support in primitives #2257

Merged
merged 9 commits into from
May 11, 2022

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Apr 29, 2022

Resolve inconsistencies in reduction support in primitives (partially addresses #2003).

  • If reduce_op is missing, + is assumed.
  • If init is missing, T{} is assumed.
  • Provides a pre-defined set of reduction operations in reduce_op.cuh
  • Provides a guidance on writing custom reduction operators.
  • Fix a bug in reduction support for thrust::tuple (std::numeric_limits does not work properly for thrust::tuple, std::numeric_limits should be applied to individual elements of thrust::tuple).

@seunghwak seunghwak added 2 - In Progress improvement Improvement / enhancement to an existing function breaking Breaking change labels Apr 29, 2022
@seunghwak seunghwak added this to the 22.06 milestone Apr 29, 2022
@seunghwak seunghwak self-assigned this Apr 29, 2022
@seunghwak seunghwak changed the title [skip-ci] Resolve inconsistencies in reduction support in primitives Resolve inconsistencies in reduction support in primitives May 2, 2022
@seunghwak seunghwak marked this pull request as ready for review May 2, 2022 19:59
@seunghwak seunghwak requested a review from a team as a code owner May 2, 2022 19:59
@codecov-commenter
Copy link

Codecov Report

Merging #2257 (9dee12b) into branch-22.06 (34a40a7) will not change coverage.
The diff coverage is n/a.

❗ Current head 9dee12b differs from pull request most recent head b2f151a. Consider uploading reports for the commit b2f151a to get more accurate results

@@              Coverage Diff              @@
##           branch-22.06    #2257   +/-   ##
=============================================
  Coverage         71.18%   71.18%           
=============================================
  Files               172      172           
  Lines             11277    11277           
=============================================
  Hits               8027     8027           
  Misses             3250     3250           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a40a7...b2f151a. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a330669 into rapidsai:branch-22.06 May 11, 2022
@seunghwak seunghwak deleted the enh_prim_reduction branch August 11, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants