Performance-optimize storing edge partition source/destination properties in (key, value) pairs #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edge partition src/dst properties using key, value pairs
…ter performnace measurements)
seunghwak
added
2 - In Progress
improvement
seunghwak
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2328 +/- ##
===============================================
Coverage ? 60.74%
===============================================
Files ? 105
Lines ? 5075
Branches ? 0
===============================================
Hits ? 3083
Misses ? 1992
Partials ? 0 Continue to review full report at Codecov.
|
seunghwak
changed the title
cpp/src/structure/graph_impl.cuh
Outdated
| static_cast<double>(num_local_unique_edge_minors) / static_cast<double>(minor_size), | ||
| raft::comms::op_t::MAX, | ||
| handle.get_stream()); | ||
| std::cout << "max_major_properties_fill_ratio=" << max_major_properties_fill_ratio |
There was a problem hiding this comment.
Residual debug statement?
There was a problem hiding this comment.
Oops, I though I deleted this but it seems like I didn't :-) I will delete this.
ChuckHastings
approved these changes
Jun 6, 2022
kaatish
approved these changes
Jun 7, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using (key, value) pairs instead of linear array for the entire source/destination range cuts memory footprint significantly when # GPUs >> (V/E)^2.
This PR performance-optimizes finding the value for the given key and also enables (key, value) pairs (this feature was previously disabled by default).
The original implementation binary searched over the entire set of local source/destination keys. This PR compared a hash table based approach (using cuCollection) and the auxiliary array based approach (described in the original DCSC paper) and selected the auxiliary array based approach.
Breaking due to few graph primitives API changes.