Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topology header #2357

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Remove the header file topology.cuh which is no longer used.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 15, 2022 23:19
@ChuckHastings ChuckHastings self-assigned this Jun 15, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 15, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 15, 2022
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I added a comment to clean-up one more our code debt).

@@ -27,8 +27,6 @@
#include <type_traits>
#include <utilities/graph_utils.cuh>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May better update this to

#include <utilities/graph_utils.cuh>

#include <type_traits>

to be consistent with the rest of the cuGraph.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorganized includes.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 21, 2022 21:21
@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 71f143e into rapidsai:branch-22.08 Jun 22, 2022
@ChuckHastings ChuckHastings deleted the remove_topology_header branch August 4, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants