Delete old nbr sampling software #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
3 - Ready for Review
improvement
seunghwak
approved these changes
Jun 23, 2022
BradReesWork
approved these changes
Jul 7, 2022
|
rerun tests |
seunghwak
approved these changes
Jul 7, 2022
| @@ -84,6 +85,7 @@ template rmm::device_uvector<int64_t> get_global_adjacency_offset( | |||
| graph_view_t<int64_t, int64_t, double, false, false> const& graph_view, | |||
| rmm::device_uvector<int64_t> const& global_degree_offsets, | |||
| rmm::device_uvector<int64_t> const& global_out_degrees); | |||
| #endif | |||
There was a problem hiding this comment.
And can I just close PR #2370?
There was a problem hiding this comment.
I think you can just close PR 2370.
I deleted both of these blocks of code (in _sg and _mg). Thanks for catching that.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time ran out during 22.06 development to replace the old code.
This PR renames the experimental version of uniform neighborhood sampling to the regular name and eliminates the original implementation.
Tagged as
breakingsince we eliminate a function from the C++ API.