Add options to extract_subgraph() to bypass renumbering and adding edge_data, exclude internal _WEIGHT_ column from edge_property_names, added num_vertices_with_properties attr
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edge_data to extraced subgraph, fixed issue with internal weight column being returned by property names API, added tests for new features and bug fix.
…hich returns the number of verts that have properties (different than the number of verts). This is needed for GNN use cases.
rlratzel
changed the title
extract_subgraph() to bypass renumbering and adding edge_data, exclude internal _WEIGHT_ column from edge_property_namesextract_subgraph() to bypass renumbering and adding edge_data, exclude internal _WEIGHT_ column from edge_property_names, added num_vertices_with_properties attr
…rtices_with_properties.
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2419 +/- ##
================================================
- Coverage 60.11% 60.06% -0.05%
================================================
Files 102 102
Lines 5155 5174 +19
================================================
+ Hits 3099 3108 +9
- Misses 2056 2066 +10
Continue to review full report at Codecov.
|
alexbarghi-nv
approved these changes
Jul 18, 2022
…, minor tests refactoring. Still need to update SG the same way.
eriknw
approved these changes
Jul 21, 2022
eriknw
added a commit
to eriknw/cugraph
that referenced
this pull request
Jul 22, 2022
- add `include_edge_data=True` keyword to `get_num_vertices` - improved docstrings of `get_num_vertices` and `get_num_edges` - change default type name to `""` - remove `num_vertices` and `num_edges` properties - use `series.value_counts` to compute counts of types (assuming types are low cardinality) - add and update tests - copy `pG.num_vertices_with_properties` tests from rapidsai#2419 MG is not quite finished yet.
BradReesWork
approved these changes
Jul 25, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to
extract_subgraph()to bypass renumbering and adding edge_data, exclude internal_WEIGHT_column fromedge_property_names.Also added a new attribute
num_vertices_with_propertieswhich returns the number of vertices with properties, which is different than the number of vertices, since vertices can be added viaadd_edge_data(). This is needed for GNN use cases which need to know how many verts have properties which can be accessed (this corresponds to the number of rows in the internal vertex prop data table).Added unit tests to verify new
extract_subgraph()options work, the newnum_vertices_with_propertiesattribute, and_WEIGHT_columns names aren't included, for both SG and MG versions.closes #2418
closes #2410