Added get_vertex_data() and get_edge_data() to SG/MG PropertyGraph
#2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edge_data to extraced subgraph, fixed issue with internal weight column being returned by property names API, added tests for new features and bug fix.
…hich returns the number of verts that have properties (different than the number of verts). This is needed for GNN use cases.
…rtices_with_properties.
…, minor tests refactoring. Still need to update SG the same way.
…8-pg_updates_for_gnns
…8-pg_updates_for_gnns2
…eneration code the same.
rlratzel
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2444 +/- ##
===============================================
Coverage ? 61.14%
===============================================
Files ? 106
Lines ? 5539
Branches ? 0
===============================================
Hits ? 3387
Misses ? 2152
Partials ? 0 Continue to review full report at Codecov.
|
eriknw
reviewed
Jul 27, 2022
…8-pg_updates_for_gnns2
…sts which did not catch the bugs, minor formatting improvement.
…8-pg_updates_for_gnns2
alexbarghi-nv
requested changes
Jul 28, 2022
VibhuJawa
suggested changes
Jul 28, 2022
…rent lack of support for unrenumbering on MG for pylibcugraph-based algos, updated tests accordingly.
|
rerun tests There was a compile failure from a cython-generated cpp file not associated with this PR, so rerunning while I investigate in case it's somehow a transient failure on the CI side. |
…8-pg_updates_for_gnns2
|
@gpucibot merge |
BradReesWork
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2421
Added
get_vertex_data()andget_edge_data()to SG and MG PropertyGraph, and corresponding tests.Prior to these methods, users had to either call
pG.annotate_dataframe()to get properties for edges or access the internal debug dataframes directly viapG._vertex_prop_dataframeandpG._edge_prop_dataframe.Users can now call
pG.get_vertex_data(vertex_ids, types, columns)to get vertex properties for the vertices specified byvertex_ids, and 'types', with data for each column specified. All args are optional and default to "all" for each category.pG.get_edge_data(edge_ids, types, columns)works the same for edges. The return value for both is a dataframe.