Don't store redundant columns in PropertyGraph Dataframes #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rapidsai#2400 I still need to update MG tests. I'll also remove the in-code assertions, since they won't always be True, because a column name could have previously been used as a property. Nevertheless, seeing these assertions pass should give us warm-fuzzies :)
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2449 +/- ##
===============================================
Coverage ? 61.15%
===============================================
Files ? 106
Lines ? 5543
Branches ? 0
===============================================
Hits ? 3390
Misses ? 2153
Partials ? 0 Continue to review full report at Codecov.
|
BradReesWork
added
improvement
|
One thing I don't like about the current state of this PR is that it makes the user use our column names for source, dest, etc. in the query string. What if |
rlratzel
approved these changes
Jul 28, 2022
alexbarghi-nv
approved these changes
Jul 28, 2022
VibhuJawa
suggested changes
Jul 28, 2022
Co-authored-by: Vibhu Jawa <vibhujawa@gmail.com>
Co-authored-by: Vibhu Jawa <vibhujawa@gmail.com>
…into remove_redundant_columns
|
Test failures are now the same as seen in other PRs: |
BradReesWork
approved these changes
Aug 2, 2022
|
@gpucibot merge |
eriknw
added a commit
to eriknw/cugraph
that referenced
this pull request
Aug 5, 2022
Updating these tests was missed in rapidsai#2449 Also, MG tests are finally working for me 🎉
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
Updating these tests was missed in #2449 Also, MG tests are finally working for me 🎉 Authors: - Erik Welch (https://github.com/eriknw) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #2511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this is to reduce memory usage.
Closes #2400
I still need to update MG tests.
I'll also remove the in-code assertions, since they won't always be True, because a column name could have previously been used as a property. Nevertheless, seeing these assertions pass should give us warm-fuzzies :)