Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake bug fix (MG related part wasn't property guarded) #2463

Closed
wants to merge 2 commits into from

Conversation

seunghwak
Copy link
Contributor

MG related parts were not properly guarded with if(BUILD_CUGRAPH_MG_TESTS), this leads to a CMake error when just building for SG.

@seunghwak seunghwak requested a review from a team as a code owner July 28, 2022 15:52
@seunghwak seunghwak self-assigned this Jul 28, 2022
@seunghwak seunghwak added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Jul 28, 2022
@seunghwak seunghwak added this to the 22.08 milestone Jul 28, 2022
@ChuckHastings
Copy link
Collaborator

Are these changes already covered in #2454 ?

@seunghwak
Copy link
Contributor Author

Addressed in #2454. Closing.

@seunghwak seunghwak closed this Jul 28, 2022
@seunghwak seunghwak deleted the bug_cmake branch August 11, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants